Skip to content

Fix Privacy link on Invite People page #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Conversation

luacmartins
Copy link
Contributor

Details

Fixes the privacy link style on Invite people page.

Fixed Issues

$ #5344

Tests

  1. Login to NewDot and make sure the account has a Workspace.
  2. Navigate to /workspace/<Workspace ID>/invite or Settings > Select Workspace > People > Invite
  3. Verify that the Privacy policy link looks like the one in the screenshots below.
  4. Click the link and verify that it opens the privacy policy page.

QA Steps

Same as above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web

Mobile Web

mweb

Desktop

desktop

iOS

ios

Android

android

@luacmartins luacmartins self-assigned this Sep 21, 2021
@luacmartins luacmartins requested a review from a team September 21, 2021 20:48
@luacmartins luacmartins marked this pull request as ready for review September 21, 2021 20:48
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team September 21, 2021 20:48
Copy link
Contributor

@marcochavezf marcochavezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@marcochavezf marcochavezf merged commit 6a4f898 into main Sep 23, 2021
@marcochavezf marcochavezf deleted the cmartins-privacyPolicy branch September 23, 2021 17:02
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcochavezf in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants